[Scamper-dev] DW's code review

Matthew Luckie mjl at luckie.org.nz
Wed May 14 09:51:34 PDT 2003


Hi Duane

thanks for the code review.  i'm working my way through the list, changing
scamper now.  most of the nits are fair comments.

the reason I use void * to hold the addresses at each hop is because that
is all the data I need - the type of address is stored in the trace
structure, so using a sockaddr seems like a waste of memory.

i could replace that void * with a

union
{
  struct in_addr  *ip4;
  struct in6_addr *ip6;
} u;

I'll post a diff against the scamper code you reviewed somewhere when i'm
done working through your list.

Thanks again

Matthew


More information about the Scamper-dev mailing list